Re: pg_recvlogical requires -d but not described on the documentation - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: pg_recvlogical requires -d but not described on the documentation
Date
Msg-id d235c2a6-fe1e-4bd1-96fa-2e2c884f211d@oss.nttdata.com
Whole thread Raw
In response to RE: pg_recvlogical requires -d but not described on the documentation  ("Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>)
Responses RE: pg_recvlogical requires -d but not described on the documentation
List pgsql-hackers

On 2025/03/18 18:17, Hayato Kuroda (Fujitsu) wrote:
> Dear Fujii-san, David,
> 
>>> BTW, I'm curious why --dbname isn't required for the --drop-slot action.
>>
>> I'm analyzing around here...
>>
> 
> Actually, replication slots can be dropped from another database where it created,
> or even from the streaming replication connection.
> I forked the new thread which fixes the description [1].
> 
> Based on the fact, there are two approaches to fix:
> 
> 1. Fix not to raise fatal error like:


It looks like commit 0c013e08cfb introduced a bug that causes "pg_recvlogical --drop-slot"
without --dbname to check whether it's connected to a specific database and fail if it's not.

This commit was added before 9.5, while pg_recvlogical was introduced in 9.4. On my env,
"pg_recvlogical --drop-slot" without --dbname worked as expected in 9.4 but started
failing in 9.5 or later.

So, I think the proper fix is to avoid raising a fatal error even when not connected to
a specific database in --drop-slot action.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION




pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: dblink: Add SCRAM pass-through authentication
Next
From: Peter Geoghegan
Date:
Subject: Re: Adding skip scan (including MDAM style range skip scan) to nbtree