Re: automatically generating node support functions - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: automatically generating node support functions
Date
Msg-id d200d6b0-0fde-d02e-b547-d00211acf8df@enterprisedb.com
Whole thread Raw
In response to Re: automatically generating node support functions  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 06.07.22 02:54, Tom Lane wrote:
> It might be enough to invent a struct-level attribute allowing
> manual assignment of node tags, ie
> 
> typedef struct MyNewNode pg_node_attr(nodetag=466)
> 
> where it'd be the programmer's responsibility to pick a nonconflicting
> tag number.  We'd only ever use that in ABI-frozen branches, so
> manual assignment of the tag value should be workable.

Yes, I'm aware of this issue, and that was also more or less my idea.

(Well, before the introduction of per-struct attributes, I was thinking 
about parsing nodes.h to see if the tag is listed explicitly.  But this 
is probably better.)



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: automatically generating node support functions
Next
From: Dilip Kumar
Date:
Subject: Re: [PATCH] Reuse Workers and Replication Slots during Logical Replication