Re: pgsql: Add Bloom filter implementation. - Mailing list pgsql-committers

On 3/31/18 21:36, Andres Freund wrote:
> Add Bloom filter implementation.

There is a compiler warning in the tests, with gcc-7:

test_bloomfilter.c: In function 'test_bloomfilter':
test_bloomfilter.c:40:38: error: '__builtin_snprintf' output may be
truncated before the last format character [-Werror=format-truncation=]
   snprintf(element, sizeof(element), "i" INT64_FORMAT, i);
                                      ^

This can be fixed by allocating one more byte for the possible sign, or
doing the whole thing in unsigned.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services