Re: v12 pg_basebackup fails against older servers (take two) - Mailing list pgsql-hackers

From Devrim Gündüz
Subject Re: v12 pg_basebackup fails against older servers (take two)
Date
Msg-id d1c507731779254bb53c93e50e02432c3236e94f.camel@gunduz.org
Whole thread Raw
In response to Re: v12 pg_basebackup fails against older servers (take two)  (Michael Paquier <michael@paquier.xyz>)
Responses Re: v12 pg_basebackup fails against older servers (take two)  (Stephen Frost <sfrost@snowman.net>)
List pgsql-hackers
Hi,

On Tue, 2019-10-22 at 19:16 +0900, Michael Paquier wrote:
> You are referring to the connection string generated in
> primary_conninfo here, right?

Right.

> It would be nice to be more compatible here.  This can be simply fixed by
> having an extra filter in GenerateRecoveryConfig() (different file between
> HEAD and REL_12_STABLE).  I also think that there is more.  On HEAD,
> channel_binding gets added to the connection string generated which
> would equally cause a failure with pg_basebackup from HEAD used for a
> v12 or older server.

https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=beeb8e2e0717065296dc7b32daba2d66f0f931dd

had a similar approach in backwards compatibility, so I also agree on fixing
whatever breaks it.

Regards,
--
Devrim Gündüz
Open Source Solution Architect, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: v12 pg_basebackup fails against older servers (take two)
Next
From: Amit Kapila
Date:
Subject: Re: Proposal: Make use of C99 designated initialisers fornulls/values arrays