Re: pgsql: Use ICU by default at initdb time. - Mailing list pgsql-committers

From Jeff Davis
Subject Re: pgsql: Use ICU by default at initdb time.
Date
Msg-id d191d5841347301a8f1238f609471ddd957fc47e.camel@j-davis.com
Whole thread Raw
In response to pgsql: Use ICU by default at initdb time.  (Jeff Davis <jdavis@postgresql.org>)
List pgsql-committers
On Thu, 2023-03-09 at 19:11 +0000, Jeff Davis wrote:
> Use ICU by default at initdb time.

I'm seeing a failure on hoverfly:


https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=hoverfly&dt=2023-03-09%2021%3A51%3A45&stg=initdb-en_US.8859-15

That's because ICU always uses UTF-8 by default. ICU works just fine
with many other encodings; is there a reason it doesn't take it from
the environment just like for provider=libc?

Of course, we still need to default to UTF-8 when the encoding from the
environment isn't supported by ICU.

Patch attached. Requires a few test fixups to adapt.

--
Jeff Davis
PostgreSQL Contributor Team - AWS



Attachment

pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: pg_walinspect: pg_get_wal_fpi_info() -> pg_get_wal_block_info()
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Fix incorrect format placeholders