Re: More time spending with "delete pending" - Mailing list pgsql-hackers

From Alexander Lakhin
Subject Re: More time spending with "delete pending"
Date
Msg-id d030cc87-641c-c2f0-b7a9-4d6669ea91d7@gmail.com
Whole thread Raw
In response to Re: More time spending with "delete pending"  (Michael Paquier <michael@paquier.xyz>)
Responses Re: More time spending with "delete pending"  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
08.07.2021 10:47, Michael Paquier wrote:
> On Thu, Jul 08, 2021 at 07:00:01AM +0300, Alexander Lakhin wrote:
>> As Tom Lane noted above, the code added with bed90759f is dubious
>> (_NtQueryInformationFile() can not be used to handle the "delete
>> pending" state as CreateFile() returns INVALID_HANDLE_VALUE in this case.)
>> Probably that change should be reverted. Should I do it along with the
>> proposed fix?
> Ah, I see.  I have managed to miss your point.  If
> _NtQueryInformationFile() cannot be used, then we'd actually miss the
> contents for standardInfo and the pending deletion.  If you could send
> everything you have, that would be helpful!  I'd like to test that
> stuff by myself, with all the contents discussed at disposal for a
> proper evaluation.
> --
Beside the aforementioned test I can only propose the extended patch,
that incorporates the undo of the changes brought by bed90759f.
With this patch that test is passed.

Best regards,
Alexander

Attachment

pgsql-hackers by date:

Previous
From: Boris Kolpackov
Date:
Subject: Re: Pipeline mode and PQpipelineSync()
Next
From: Tom Lane
Date:
Subject: Re: "debug_invalidate_system_caches_always" is too long