Postgres Pro
Downloads
Home   >   mailing lists

Re: Logical Replication - improve error message while adding tables to the publication in check_publication_add_relation - Mailing list pgsql-hackers

From Euler Taveira
Subject Re: Logical Replication - improve error message while adding tables to the publication in check_publication_add_relation
Date
Msg-id cec3dc2c-b7a2-4813-8f90-65735295ba63@www.fastmail.com
Whole thread Raw
In response to Re: Logical Replication - improve error message while adding tables to the publication in check_publication_add_relation  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: Logical Replication - improve error message while adding tables to the publication in check_publication_add_relation
List pgsql-hackers
Tree view
On Fri, Nov 12, 2021, at 9:41 AM, Daniel Gustafsson wrote:
> On 4 Nov 2021, at 05:24, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> wrote:
> 
> On Wed, Nov 3, 2021 at 6:21 PM Daniel Gustafsson <daniel@yesql.se> wrote:
>> 
>>> On 26 Jul 2021, at 09:33, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> wrote:
>> 
>>> PSA v7.
>> 
>> This patch no longer applies on top of HEAD, please submit a rebased version.
> 
> Here's a rebased v8 patch. Please review it.

This improves the user experience by increasing the granularity of error
reporting, and maps well with the precedent set in 81d5995b4.  I'm marking this
Ready for Committer and will go ahead and apply this unless there are
objections.
Shouldn't we modify errdetail_relkind_not_supported() to include relpersistence
as a 2nd parameter and move those messages to it? I experiment this idea with
the attached patch. The idea is to provide a unique function that reports
accurate detail messages.


--
Euler Taveira
EDB   https://www.enterprisedb.com/

Attachment

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: support for MERGE
Next
From: Justin Pryzby
Date:
Subject: Re: RFC: Logging plan of the running query