Postgres Pro
Downloads
Home   >   mailing lists

AppendStringInfoChar instead of appendStringInfoString - Mailing list pgsql-hackers

From Hou, Zhijie
Subject AppendStringInfoChar instead of appendStringInfoString
Date
Msg-id ce9a8564ccf1435eacf14bb7364ae9de@G08CNEXMBPEKD05.g08.fujitsu.local
Whole thread Raw
Responses Re: AppendStringInfoChar instead of appendStringInfoString  (Justin Pryzby <pryzby@telsasoft.com>)
List pgsql-hackers
Tree view 
Hi

In (/src/backend/replication/backup_manifest.c)

I found the following code:

    appendStringInfoString(&buf, "\n");
    appendStringInfoString(&buf, "\"");

Since only one bit string is appended here,
I think it will be better to call appendStringInfoChar.

Best reagrds,
houzj
Attachment

pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: Transactions involving multiple postgres foreign servers, take 2
Next
From: "tsunakawa.takay@fujitsu.com"
Date:
Subject: RE: [Patch] Optimize dropping of relation buffers using dlist