Re: [HACKERS] Hooks - Mailing list pgsql-hackers

From Jim Nasby
Subject Re: [HACKERS] Hooks
Date
Msg-id ce97d16c-df0d-f674-0525-a3b435bba69c@BlueTreble.com
Whole thread Raw
In response to Re: [HACKERS] Hooks  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [HACKERS] Hooks
Re: [HACKERS] Hooks
List pgsql-hackers
On 12/27/16 7:41 PM, David Fetter wrote:
> I see it as larger in scope than mine because it changes how we do
> things as a project.  An example of the kind of thing that this raises
> is enforcement.  Will something (or someone) check that new hooks have
> this?  Will somebody check for comment skew when the APIs change?
> What happens when somebody forgets?

Can we reduce the scope of this to a manageable starting point? I'm 
guessing that all existing hooks share certain characteristics that it'd 
be pretty easy to detect. If you can detect the hook (which I guess 
means finding a static variable with hook in the name) then you can 
verify that there's an appropriate comment block. I'm guessing someone 
familiar with tools like doxygen could set that up without too much 
effort, and I'd be surprised if the community had a problem with it.
-- 
Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX
Experts in Analytics, Data Architecture and PostgreSQL
Data in Trouble? Get it in Treble! http://BlueTreble.com
855-TREBLE2 (855-873-2532)



pgsql-hackers by date:

Previous
From: Jim Nasby
Date:
Subject: Re: [HACKERS] merging some features from plpgsql2 project
Next
From: Craig Ringer
Date:
Subject: Re: [HACKERS] Hooks