Re: GISTSTATE is too large - Mailing list pgsql-hackers

From Andreas Karlsson
Subject Re: GISTSTATE is too large
Date
Msg-id cc5e30ca-c479-2eac-3c78-5b453469a150@proxel.se
Whole thread Raw
In response to GISTSTATE is too large  (Andres Freund <andres@anarazel.de>)
Responses Re: GISTSTATE is too large
Re: GISTSTATE is too large
List pgsql-hackers
On 4/26/21 12:20 AM, Andres Freund wrote:
> It seems pretty clear that this should be changed to be something more
> like
> 
> [...]
> 
> with initGISTstate allocating based on
> IndexRelationGetNumberOfKeyAttributes() instead of using a constant.
> 
> And then subsequently change GIST_COL_STATE to embed the
> FunctionCallInfo, rather than initializiing them on the stack for every
> call.
> 
> 
> I'm not planning on doing this work, but I thought it's sensible to send
> to the list anyway.

I did the first part since it seemed easy enough and an obvious win for 
all workloads.

Andreas

Attachment

pgsql-hackers by date:

Previous
From: Asif Rehman
Date:
Subject: Re: [PATCH] expand the units that pg_size_pretty supports on output
Next
From: Zhihong Yu
Date:
Subject: Re: GISTSTATE is too large