On 2/22/22 18:19, Justin Pryzby wrote:
> As writen, this patch uses zstd level=1 (whereas the ZSTD's default compress
> level is 6).
I think this choice needs to be supported by some benchmarks.
>
> 0001 adds support for zstd
> 0002 makes more efficient our use of bits in the WAL header
> 0003 makes it the default compression, to exercise on CI (windows will fail).
> 0004 adds support for zstd-level
> 0005-6 are needed to allow recovery tests to pass when wal compression is enabled;
> 0007 (not included) also adds support for zlib. I'm of the impression nobody
> cares about this, otherwise it would've been included 5-10 years ago.
>
> Only 0001 should be reviewed for pg15 - the others are optional/future work.
I don't see why patch 5 shouldn't be applied forthwith.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
