Re: RFC: Logging plan of the running query - Mailing list pgsql-hackers

From Andrey Lepikhov
Subject Re: RFC: Logging plan of the running query
Date
Msg-id c8322c0c-1f75-4e6b-ab91-b1469d1c778e@postgrespro.ru
Whole thread Raw
In response to Re: RFC: Logging plan of the running query  (torikoshia <torikoshia@oss.nttdata.com>)
Responses Re: RFC: Logging plan of the running query
List pgsql-hackers
On 25/9/2023 14:21, torikoshia wrote:
> On 2023-09-20 14:39, Lepikhov Andrei wrote:
> Hmm, as a test, I made sure to call ProcessLogQueryPlanInterrupt() on 
> all CFI using 
> v28-0002-Testing-attempt-logging-plan-on-ever-CFI-call.patch, and then 
> ran the following query but did not cause any problems.
> 
> ```
> =# CREATE TABLE test();
> =# CREATE OR REPLACE FUNCTION ddl() RETURNS void AS $$
> BEGIN
>    EXECUTE format('ALTER TABLE test ADD COLUMN x integer;');
>    PERFORM pg_sleep(5);
> END; $$ LANGUAGE plpgsql VOLATILE;
> =# SELECT ddl();
> ```
> 
> Is this the case you're worrying about?

I didn't find a problem either. I just feel uncomfortable if, at the 
moment of interruption, we have a descriptor of another query than the 
query have been executing and holding resources.

-- 
regards,
Andrey Lepikhov
Postgres Professional




pgsql-hackers by date:

Previous
From: Andrey Lepikhov
Date:
Subject: Re: POC: GUC option for skipping shared buffers in core dumps
Next
From: Pavel Borisov
Date:
Subject: Re: Index range search optimization