Re: [HACKERS] Logical Replication WIP - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [HACKERS] Logical Replication WIP
Date
Msg-id c7236ac8-b106-4b6c-72d0-fb127f339804@2ndquadrant.com
Whole thread Raw
In response to Re: Logical Replication WIP  (Petr Jelinek <petr.jelinek@2ndquadrant.com>)
Responses Re: [HACKERS] Logical Replication WIP  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On 12/8/16 4:10 PM, Petr Jelinek wrote:
> On 08/12/16 20:16, Peter Eisentraut wrote:
>> On 12/6/16 11:58 AM, Peter Eisentraut wrote:
>>> On 12/5/16 6:24 PM, Petr Jelinek wrote:
>>>> I think that the removal of changes to ReplicationSlotAcquire() that you
>>>> did will result in making it impossible to reacquire temporary slot once
>>>> you switched to different one in the session as the if (active_pid != 0)
>>>> will always be true for temp slot.
>>>
>>> I see.  I suppose it's difficult to get a test case for this.
>>
>> I created a test case, saw the error of my ways, and added your code
>> back in.  Patch attached.
>>
> 
> Hi,
> 
> I am happy with this version, thanks for moving it forward.

committed

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: [HACKERS] Declarative partitioning - another take
Next
From: Fujii Masao
Date:
Subject: Re: [HACKERS] [COMMITTERS] pgsql: Add support for temporary replication slots