Postgres Pro
Downloads
Home   >   mailing lists

Re: Modifying data type of slot_keep_segs from XLogRecPtr to XLogSegNo - Mailing list pgsql-hackers

From torikoshia
Subject Re: Modifying data type of slot_keep_segs from XLogRecPtr to XLogSegNo
Date
Msg-id c6da1bbab64e80b5126de5be5f36d906@oss.nttdata.com
Whole thread Raw
In response to Re: Modifying data type of slot_keep_segs from XLogRecPtr to XLogSegNo  (Fujii Masao <masao.fujii@oss.nttdata.com>)
Responses Re: Modifying data type of slot_keep_segs from XLogRecPtr to XLogSegNo
List pgsql-hackers
Tree view 
On 2020-07-08 11:15, Fujii Masao wrote:
> On 2020/07/08 11:02, torikoshia wrote:
>> Hi,
>> 
>> Currently, slot_keep_segs is defined as "XLogRecPtr" in KeepLogSeg(),
>> but it seems that should be "XLogSegNo" because this variable is
>> segment number.
>> 
>> How do you think?
> 
> I agree that using XLogRecPtr for slot_keep_segs is incorrect.
> But this variable indicates the number of segments rather than
> segment no, uint64 seems better. Thought?

That makes sense.
The number of segments and segment number are different.


Regards,

--
Atsushi Torikoshi
NTT DATA CORPORATION

pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: Performing partition pruning using row value
Next
From: David Gilman
Date:
Subject: Re: Warn when parallel restoring a custom dump without data offsets