Postgres Pro
Downloads
Home   >   mailing lists

Re: Modifying data type of slot_keep_segs from XLogRecPtr to XLogSegNo - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Modifying data type of slot_keep_segs from XLogRecPtr to XLogSegNo
Date
Msg-id 8bb8426f-0bc1-1b98-9e2a-ca1c1be25acf@oss.nttdata.com
Whole thread Raw
In response to Modifying data type of slot_keep_segs from XLogRecPtr to XLogSegNo  (torikoshia <torikoshia@oss.nttdata.com>)
Responses Re: Modifying data type of slot_keep_segs from XLogRecPtr to XLogSegNo  (torikoshia <torikoshia@oss.nttdata.com>)
List pgsql-hackers
Tree view 

On 2020/07/08 11:02, torikoshia wrote:
> Hi,
> 
> Currently, slot_keep_segs is defined as "XLogRecPtr" in KeepLogSeg(),
> but it seems that should be "XLogSegNo" because this variable is
> segment number.
> 
> How do you think?

I agree that using XLogRecPtr for slot_keep_segs is incorrect.
But this variable indicates the number of segments rather than
segment no, uint64 seems better. Thought?

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

pgsql-hackers by date:

Previous
From: "movead.li@highgo.ca"
Date:
Subject: Re: A patch for get origin from commit_ts.
Next
From: Fujii Masao
Date:
Subject: Re: [doc] modifying unit from characters to bytes