Re: [PATCH] pgbench: new feature allowing to launch shell commands - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] pgbench: new feature allowing to launch shell commands
Date
Msg-id c64c5f8b0908062120p6bab95e2saba3dabe3e895532@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] pgbench: new feature allowing to launch shell commands  (Itagaki Takahiro <itagaki.takahiro@oss.ntt.co.jp>)
Responses Re: [PATCH] pgbench: new feature allowing to launch shell commands  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
Yes it dramatically decreases the transaction flow.
This function has not been implemented at all for performance but for analysis purposes.
I used it mainly to have a look at state files size in pg_twophase for transactions that are prepared but not committed.
 
Regards

On Fri, Aug 7, 2009 at 12:55 PM, Itagaki Takahiro <itagaki.takahiro@oss.ntt.co.jp> wrote:

Michael Paquier <michael.paquier@gmail.com> wrote:

> > Here is a short patch implementing a new feature in pgbench so as to allow
> > shell commands to be launched in a transaction file of pgbench.
> > \shell ls ~/pg_twophase;

+1 for \shell command itself, but does the performance fit for your purpose?
Spawning a new process is not so cheap, no?

-1 for -P option because it is too narrow purpose and 'ls' and '/tmp/'
is not portable. We don't need to include your workload because you can
use -f FILENAME to run your benchmark script.

Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center





--
Michael Paquier

NTT OSSC

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: [PATCH] pgbench: new feature allowing to launch shell commands
Next
From: Pavel Stehule
Date:
Subject: Re: Fwd: [BUGS] fix: plpgsql: return query and dropped columns problem