On 4/12/22 11:19 AM, Tom Lane wrote:
> "Jonathan S. Katz" <jkatz@postgresql.org> writes:
>> On 4/11/22 4:11 PM, Tom Lane wrote:
>>> This idea does somewhat address my unhappiness upthread about printing
>>> values with source = 'internal', but I see that it gets confused by
>>> some GUCs with custom show hooks, like unix_socket_permissions.
>>> Maybe it needs to be "source != 'default' AND setting != boot_val"?
>
>> Running through a few GUCs, that seems reasonable. Happy to test the
>> patch out prior to commit to see if it renders better.
>
> It'd just look like this, I think. I see from looking at guc.c that
> boot_val can be NULL, so we'd better use IS DISTINCT FROM.
(IS DISTINCT FROM is pretty handy :)
I tested it and I like this a lot better, at least it's much more
consolidated. They all seem to be generated (directories, timezones,
collations/encodings).
The one exception to this seems to be "max_stack_depth", which is
rendering on my "\dconfig" though I didn't change it, an it's showing
it's default value of 2MB. "boot_val" says 100, "reset_val" says 2048,
and it's commented out in my postgresql.conf. Do we want to align that?
That said, the patch itself LGTM.
Jonathan
