Re: [HACKERS] cast result of copyObject() - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [HACKERS] cast result of copyObject()
Date
Msg-id c2e5f74f-5602-926a-6999-78857ffd8a03@2ndquadrant.com
Whole thread Raw
In response to Re: [HACKERS] cast result of copyNode()  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: [HACKERS] cast result of copyNode()  (Mark Dilger <hornschnorter@gmail.com>)
List pgsql-hackers
> The problem this patch would address is that currently you can write
> 
> SomeNode *x = ...;
> 
> ...
> 
> 
> OtherNode *y = copyObject(x);
> 
> and there is no notice about that potential mistake.
> 
> This patch makes that an error.
> 
> If you are sure about what you are doing, you can add a cast.  But
> casting the result of copyObject() should be limited to a few specific
> cases where the result is assigned to a generic Node * or something like
> that.

Updated patch, which I will register in the commit fest for some wider
portability testing (Windows!).

(changed subject copyNode -> copyObject (was excited about castNode at
the time))

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: [HACKERS] Performance degradation in TPC-H Q18
Next
From: Robert Haas
Date:
Subject: Re: [HACKERS] PATCH: Make pg_stop_backup() archive wait optional