On Tue, 2024-11-26 at 17:11 -0500, Corey Huinker wrote:
>
> > * Why does binary upgrade cause statistics to be dumped? Can you
> > just
> > make pg_upgrade specify the appropriate set of flags?
> >
>
>
> That decision goes back a ways, I tried to dig in the archives last
> night but I was getting a Server Error on postgresql.org.
I suggest that pg_upgrade be changed to pass --no-data to pg_dump,
rather than --schema-only.
That way, you don't need to create a special case for the pg_dump
default that depends on whether it's a binary upgrade or not.
If wanted, there could also be a new option to pg_upgrade to specify --
with-statistics (default, passes --no-data to pg_dump) or --no-
statistics (passes --schema-only to pg_dump). But that option is
probably not necessary; everyone upgrading probably wants the stats.
Regards,
Jeff Davis
