Re: Unify DLSUFFIX on Darwin - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Unify DLSUFFIX on Darwin
Date
Msg-id c25ede4e-d1ad-5d0c-e2eb-a3752063c399@enterprisedb.com
Whole thread Raw
In response to Re: Unify DLSUFFIX on Darwin  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 24.06.22 16:13, Tom Lane wrote:
> [ thinks for a bit... ]  Might be worth double-checking that pg_upgrade
> doesn't get confused in a cross-version upgrade.  A quick grep doesn't
> find that it refers to DLSUFFIX anywhere, but it definitely does pay
> attention to extensions' shared library names.

pg_upgrade just checks that it can "LOAD" whatever it finds in probin. 
So this will work if extensions use the recommended extension-free file 
names.  If they don't, they should get a clean failure.

If this becomes a problem in practice, we could make pg_dump 
automatically adjust the probin on upgrade from an old version.

I have committed this now.  We can see how it goes.



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: [BUG] Logical replication failure "ERROR: could not map filenode "base/13237/442428" to relation OID" with catalog modifying txns
Next
From: Michael Paquier
Date:
Subject: Re: Improve TAP tests of pg_upgrade for cross-version tests