Hello hackers,
03.05.2024 17:36, David Rowley wrote:
> I pushed the patch after only adjusting the path in the docs which had
> "module" rather than "modules".
Please look at another bunch of inconsistencies/orphaned entities I found
in the tree, with the possible substitutions:
errmsg_buf -> errormsg_buf
(coined by 6b18b3fe2)
NoMovementScanDirectionScans -> NoMovementScanDirection
(introduced with e9aaf0632, discussed in [1], but still seems inaccurate)
XLogReadRecordInternal -> XLogReadRecord
(from 3f1ce9734, align with a comment above: "Start and end point of last
record returned by XLogReadRecord().")
BYPASS_ALLOWCONN -> BGWORKER_BYPASS_ROLELOGINCHECK (see 492217301)
xs_ctup.t_self -> xs_heaptid (see c2fe139c2 and 304532421)
pgStatShmLookupCache -> pgStatLocal.shmem (coined by 5891c7a8e)
smgr_fsm_nblocks and smgr_vm_nblocks -> smgr_cached_nblocks
(see the same comment updated by c5315f4f4)
XID becomes older than GlobalXmin -> XID becomes visible to everyone
(in accordance with dc7420c2c9 src/backend/access/gist/gistutil.c)
gen-rtab - remove (non-existing since db7d1a7b0)
BARRIER_SHOULD_CHECK - remove (unused since a3ed4d1ef)
EXE_EXT - remove (unused since f06b1c598)
endterm - remove
(see 60c90c16c -- Use xreflabel attributes instead of endterm ...)
xl_commit_ts_set, SizeOfCommitTsSet - remove (unused since 08aa89b32)
The corresponding patch is attached for your convenience.
[1] https://www.postgresql.org/message-id/20230131140224.7j6gbcsfwmad2a4b%40liskov
Best regards,
Alexander
