Postgres Pro
Downloads
Home   >   mailing lists

Re: bms_prev_member won't work correctly if bitmapword is 64-bits - Mailing list pgsql-hackers

From Teodor Sigaev
Subject Re: bms_prev_member won't work correctly if bitmapword is 64-bits
Date
Msg-id c1147149-2969-d6b3-5649-e9416bba9c27@sigaev.ru
Whole thread Raw
In response to bms_prev_member won't work correctly if bitmapword is 64-bits  (David Rowley <david.rowley@2ndquadrant.com>)
Responses Re: bms_prev_member won't work correctly if bitmapword is 64-bits
List pgsql-hackers
Tree view 
Thank you, pushed

David Rowley wrote:
> bms_prev_member mistakenly has a hardcoded 24 in the function. This
> should really be BITS_PER_BITMAPWORD - 8 so that it is properly set to
> 56 if someone compiles with 64-bit bitmapwords.
> 
> The attached fixes this and also adds a test to exercise the function
> a bit. [1] indicates there's currently no coverage of this function at
> all.
> 
> [1] https://coverage.postgresql.org/src/backend/nodes/bitmapset.c.gcov.html
> 

-- 
Teodor Sigaev                                   E-mail: teodor@sigaev.ru
                                                    WWW: http://www.sigaev.ru/

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: wal_consistency_checking reports an inconsistency on masterbranch
Next
From: Alvaro Herrera
Date:
Subject: Re: minor fix for CloneRowTriggersToPartition