Re: psql - factor out echo code - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: psql - factor out echo code
Date
Msg-id c02d0269-9bf4-0411-82e7-f837fa38cd90@enterprisedb.com
Whole thread Raw
In response to Re: psql - factor out echo code  (Pavel Stehule <pavel.stehule@gmail.com>)
Responses Re: psql - factor out echo code  ("Gregory Stark (as CFM)" <stark.cfm@gmail.com>)
List pgsql-hackers
On 01.12.22 08:27, Pavel Stehule wrote:
> st 30. 11. 2022 v 10:43 odesílatel Fabien COELHO <coelho@cri.ensmp.fr 
> <mailto:coelho@cri.ensmp.fr>> napsal:
> 
> 
>      >> Now some of the output generated by test_extdepend gets a bit
>      >> confusing:
>      >> +-- QUERY:
>      >> +
>      >> +
>      >> +-- QUERY:
>      >>
>      >> That's not entirely this patch's fault.  Still that's not really
>      >> intuitive to see the output of a query that's just a blank spot..
>      >
>      > Hmmm.
>      >
>      > What about adding an explicit \echo before these empty outputs to
>     mitigate
>      > the possible induced confusion?
> 
>     \echo is not possible.
> 
>     Attached an attempt to improve the situation by replacing empty
>     lines with
>     comments in this test.
> 
> 
> I can confirm so all regress tests passed

I think this patch requires an up-to-date summary and explanation.  The 
thread is over a year old and the patch has evolved quite a bit.  There 
are some test changes that are not explained.  Please provide more 
detail so that the patch can be considered.




pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Rework of collation code, extensibility
Next
From: Alvaro Herrera
Date:
Subject: Re: Helper functions for wait_for_catchup() in Cluster.pm