Re: Add version macro to libpq-fe.h - Mailing list pgsql-hackers

From Boris Kolpackov
Subject Re: Add version macro to libpq-fe.h
Date
Msg-id boris.20210618154240@codesynthesis.com
Whole thread Raw
In response to Re: Add version macro to libpq-fe.h  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Add version macro to libpq-fe.h
Re: Add version macro to libpq-fe.h
List pgsql-hackers
Tom Lane <tgl@sss.pgh.pa.us> writes:

> I think putting a version number as such in there is a truly
> horrid idea.  However, I could get behind adding a boolean flag
> that says specifically whether the pipeline feature exists.
> Then you'd do something like
> 
> #ifdef LIBPQ_HAS_PIPELINING
> 
> rather than embedding knowledge of exactly which release
> added that.

That would be even better, but I agree with what others have
said: we would have to keep adding such feature test macros
going forward.

I think ideally you would want to have both since the version
macro could still be helpful in dealing with "features" that you
did not plan to add (aka bugs).


> Comparing v13 and v14 libpq-fe.h, I see that there is a solution
> available now: "#ifdef PQ_QUERY_PARAM_MAX_LIMIT".

Hm, it must have been added recently since I don't see it in 14beta1.
But thanks for the pointer, if nothing better comes up this will
have to do.



pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Re: Refactor "mutually exclusive options" error reporting code in parse_subscription_options
Next
From: Fabien COELHO
Date:
Subject: Re: pgbench bug candidate: negative "initial connection time"