On 09/20/2016 12:45 PM, Jeff Janes wrote:
> Is the 2nd "1" in this call needed?
>
> SELECT * FROM hash_page_stats(get_raw_page('mytab_index', 1), 1)
>
> As far as I can tell, that argument is only used to stuff into the output
> field "blkno", it is not used to instruct the interpretation of the raw
> page itself. It doesn't seem worthwhile to have the parameter that only
> echos back to the user what the user already put in (twice). The only
> existing funtions which take the blkno argument are those that don't use
> the get_raw_page style.
>
> Also, should we document what the single letter values mean in the
> hash_page_stats.type column? It is not obvious that 'i' means bitmap, for
> example.
>
Adjusted in v4. Code/doc will need an update once the CHI patch goes in.
Best regards,
Jesper
