On 2025-07-28 Mo 8:08 AM, Daniel Gustafsson wrote:
On 17 Jul 2025, at 10:33, Nazir Bilal Yavuz <byavuz81@gmail.com> wrote:
On Wed, 16 Jul 2025 at 18:24, Jacob Champion <jacob.champion@enterprisedb.com> wrote:
Is there anything else in particular you'd like review on? (I've
marked this patchset RfC.)
Reading over the v6 version posted upthread, I agree with the patch being
ready. Are you taking care of it Jacob?
- # disable -Dnls as the number of files it creates cause a noticable slowdown
+ # -Dnls need to be disabled as the number of files it creates cause a noticable slowdown
I think this should be s/noticable/noticeable/ (which is a nitpick a commmitter
can deal with, no need for a new version IMO).
At the same time they should do:
s/need/needs/
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
