Re: Explicitly enable meson features in CI - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Explicitly enable meson features in CI
Date
Msg-id A4592429-98D2-4B92-856D-F2A9D5129110@yesql.se
Whole thread Raw
In response to Re: Explicitly enable meson features in CI  (Nazir Bilal Yavuz <byavuz81@gmail.com>)
Responses Re: Explicitly enable meson features in CI
Re: Explicitly enable meson features in CI
List pgsql-hackers
> On 17 Jul 2025, at 10:33, Nazir Bilal Yavuz <byavuz81@gmail.com> wrote:
> On Wed, 16 Jul 2025 at 18:24, Jacob Champion <jacob.champion@enterprisedb.com> wrote:

>> Is there anything else in particular you'd like review on? (I've
>> marked this patchset RfC.)

Reading over the v6 version posted upthread, I agree with the patch being
ready.  Are you taking care of it Jacob?

-  # disable -Dnls as the number of files it creates cause a noticable slowdown
+  # -Dnls need to be disabled as the number of files it creates cause a noticable slowdown

I think this should be s/noticable/noticeable/ (which is a nitpick a commmitter
can deal with, no need for a new version IMO).

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Ajin Cherian
Date:
Subject: Re: 024_add_drop_pub.pl might fail due to deadlock
Next
From: Ajin Cherian
Date:
Subject: Re: 024_add_drop_pub.pl might fail due to deadlock