Re: [PATCH] Print error when libpq-refs-stamp fails - Mailing list pgsql-hackers

From Anton Voloshin
Subject Re: [PATCH] Print error when libpq-refs-stamp fails
Date
Msg-id bd2c8409-d6b3-5de9-ba0f-40c1381f630f@postgrespro.ru
Whole thread Raw
In response to [PATCH] Print error when libpq-refs-stamp fails  (Rachel Heaton <rachelmheaton@gmail.com>)
Responses Re: [PATCH] Print error when libpq-refs-stamp fails  (Jacob Champion <pchampion@vmware.com>)
List pgsql-hackers
Hello,

On 28/09/2021 05:55, Rachel Heaton wrote:
> Hello,
> 
> While developing I got this error and it was difficult to figure out 
> what was going on.
> 
> Thanks to Jacob, I was able to learn the context of the failure, so we 
> created this small patch.

-    ! nm -A -u $< 2>/dev/null | grep -v __cxa_atexit | grep exit
+    @if nm -a -u $< 2>/dev/null | grep -v __cxa_atexit | grep exit; then \
+        echo 'libpq must not be linked against any library calling exit'; 
exit 1; \
+    fi

Could you please confirm that the change from -A to -a in nm arguments 
in this patch is intentional?

-- 
Anton Voloshin
Postgres Professional, The Russian Postgres Company
https://postgrespro.ru



pgsql-hackers by date:

Previous
From: Jacob Champion
Date:
Subject: Re: Support for NSS as a libpq TLS backend
Next
From: Shruthi Gowda
Date:
Subject: Re: preserving db/ts/relfilenode OIDs across pg_upgrade (was Re: storing an explicit nonce)