Re: Failed to request an autovacuum work-item in silence - Mailing list pgsql-hackers

From Ildar Musin
Subject Re: Failed to request an autovacuum work-item in silence
Date
Msg-id bd1995f9-1057-8e7e-5011-c1f1298e8867@postgrespro.ru
Whole thread Raw
In response to Re: Failed to request an autovacuum work-item in silence  (Masahiko Sawada <sawada.mshk@gmail.com>)
Responses Re: Failed to request an autovacuum work-item in silence  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers
Hi,

autovac_get_workitem_name() declaration seems redundant and should be 
removed. The same thing with including "utils/lsyscache.h" in brin.c.

The 'requested' variable in brininsert() I would again rename to 
something like 'success' because a work item is requested anyway but 
what matters is whether the request was satisfied/successful.

Except for those two points everything is fine and works as expected.


-- 
Ildar Musin
i.musin@postgrespro.ru


pgsql-hackers by date:

Previous
From: Michail Nikolaev
Date:
Subject: Re: [WIP PATCH] Index scan offset optimisation using visibility map
Next
From: "Shinoda, Noriyoshi"
Date:
Subject: [HACKERS] Commitfest 2018-9 duplicate patch deletion request.