Re: remove more archiving overhead - Mailing list pgsql-hackers

From David Steele
Subject Re: remove more archiving overhead
Date
Msg-id ba7e11b0-054d-1d26-bafd-7a2bc97f11f7@pgmasters.net
Whole thread Raw
In response to Re: remove more archiving overhead  (Nathan Bossart <nathandbossart@gmail.com>)
Responses Re: remove more archiving overhead
List pgsql-hackers
On 7/7/22 14:22, Nathan Bossart wrote:
> On Thu, Jul 07, 2022 at 10:51:42AM -0700, Nathan Bossart wrote:
>> +    library to ensure that it indeed does not overwrite an existing file.  When
>> +    a pre-existing file is encountered, the archive library may return
>> +    <literal>true</literal> if the WAL file has identical contents to the
>> +    pre-existing archive.  Alternatively, the archive library can return
> 
> This should likely say something about ensuring the pre-existing file is
> persisted to disk before returning true.

Agreed.

Also, I'd prefer to remove "indeed" from this sentence (yes, I see that 
was in the original text):

+    library to ensure that it indeed does not overwrite an existing

Regards,
-David



pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: explain analyze rows=%.0f
Next
From: Tom Lane
Date:
Subject: Re: Select Reference Page - Make Join Syntax More Prominent