On 7/7/22 14:22, Nathan Bossart wrote:
> On Thu, Jul 07, 2022 at 10:51:42AM -0700, Nathan Bossart wrote:
>> + library to ensure that it indeed does not overwrite an existing file. When
>> + a pre-existing file is encountered, the archive library may return
>> + <literal>true</literal> if the WAL file has identical contents to the
>> + pre-existing archive. Alternatively, the archive library can return
>
> This should likely say something about ensuring the pre-existing file is
> persisted to disk before returning true.
Agreed.
Also, I'd prefer to remove "indeed" from this sentence (yes, I see that
was in the original text):
+ library to ensure that it indeed does not overwrite an existing
Regards,
-David