Re: Using defines for protocol characters - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Using defines for protocol characters
Date
Msg-id b9b949be-dff6-e75f-c95b-71afc70cfa5d@eisentraut.org
Whole thread Raw
In response to Re: Using defines for protocol characters  (Dave Cramer <davecramer@gmail.com>)
Responses Re: Using defines for protocol characters
List pgsql-hackers
1. As was discussed, these definitions should go into 
src/include/libpq/pqcomm.h, not a new file.

2. I would prefer an underscore after PgMsg, like PqMsg_DescribeRequest, 
so it's easier to visually locate the start of the actual message name.

3. IMO, the names of the protocol messages in protocol.sgml are 
canonical.  Your patch appends "Request" and "Response" in cases where 
that is not part of the actual name.  Also, some messages are documented 
to go both ways, so this separation doesn't make sense strictly 
speaking.  Please use the names as in protocol.sgml without augmenting them.




pgsql-hackers by date:

Previous
From: Ashutosh Bapat
Date:
Subject: Re: Report planning memory in EXPLAIN ANALYZE
Next
From: David Rowley
Date:
Subject: Re: Report planning memory in EXPLAIN ANALYZE