Re: [PATCH] Add CANONICAL option to xmlserialize - Mailing list pgsql-hackers

From Jim Jones
Subject Re: [PATCH] Add CANONICAL option to xmlserialize
Date
Msg-id b97d5dd8-a346-ff62-d65c-f025af6ce383@uni-muenster.de
Whole thread Raw
In response to Re: [PATCH] Add CANONICAL option to xmlserialize  (Chapman Flack <chap@anastigmatix.net>)
Responses Re: [PATCH] Add CANONICAL option to xmlserialize
List pgsql-hackers
Hi Chap

On 04.10.23 23:05, Chapman Flack wrote:
> I hope I'm not butting in, but I too would be leery of any default
> behavior that's going to say thing1 and thing2 are the same thing
> but ignoring (name part of thing here). If that's the comparison
> I mean to make, and it's as easy as CANONICAL WITHOUT COMMENTS
> to say that's what I mean, I'd be happy to write that. It also means
> that the next person reading my code will know "oh, he means
> 'same' in *that* way", without having to think about it.

That's a very compelling argument. Thanks for that!

It is indeed clearer to only remove items from the result set if 
explicitly said so.

v8 attached changes de default behaviour to WITH COMMENTS.

Best,

Jim

Attachment

pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: [PATCH] Fix memory leak in memoize for numeric key
Next
From: Peter Eisentraut
Date:
Subject: Re: Remove MSVC scripts from the tree