Re: wal stats questions - Mailing list pgsql-hackers

From Andres Freund
Subject Re: wal stats questions
Date
Msg-id b5e6e6ee-eed5-42f6-8e9c-b8178cca0655@www.fastmail.com
Whole thread Raw
In response to Re: wal stats questions  (Fujii Masao <masao.fujii@oss.nttdata.com>)
List pgsql-hackers
Hi

On Thu, Apr 22, 2021, at 06:42, Fujii Masao wrote:
> 
> 
> On 2021/04/21 18:31, Masahiro Ikeda wrote:
> >> BTW, is it better to change PgStat_Counter from int64 to uint64 because> there aren't any counters with negative
number?
> 
> On second thought, it's ok even if the counters like wal_records get overflowed.
> Because they are always used to calculate the diff between the previous and
> current counters. Even when the current counters are overflowed and
> the previous ones are not, WalUsageAccumDiff() seems to return the right
> diff of them. If this understanding is right, I'd withdraw my comment and
> it's ok to use "long" type for those counters. Thought?

Why long? It's of a platform dependent size, which doesn't seem useful here?

Andres



pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: multi-install PostgresNode fails with older postgres versions
Next
From: Mark Dilger
Date:
Subject: Re: multi-install PostgresNode fails with older postgres versions