On 2022-08-17 We 17:12, Israel Barth Rubio wrote:
> Hello Andrew,
>
> Thanks for reviewing this patch
[...]
>
> I am attaching the new patch, containing the above test in the regress
> suite.
>
Thanks, this looks good but there are some things that need attention:
. There needs to be a check that this is being used with COPY FROM, and
the restriction needs to be stated in the docs and tested for. c.f.
FORCE NULL.
. There needs to be support for this in psql's tab_complete.c, and
appropriate tests added
. There needs to be support for it in contrib/file_fdw/file_fdw.c, and a
test added
. The tests should include psql's \copy as well as sql COPY
. I'm not sure we need a separate regression test file for this.
Probably these tests can go at the end of src/test/regress/sql/copy2.sql.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
