Re: [PATCH] Provide more information to filter_prepare - Mailing list pgsql-hackers

From Markus Wanner
Subject Re: [PATCH] Provide more information to filter_prepare
Date
Msg-id b4ccd487-ce47-9134-5423-44dcffd1fafe@enterprisedb.com
Whole thread Raw
In response to Re: [PATCH] Provide more information to filter_prepare  (vignesh C <vignesh21@gmail.com>)
Responses Re: [PATCH] Provide more information to filter_prepare  (vignesh C <vignesh21@gmail.com>)
List pgsql-hackers
On 29.03.21 12:18, vignesh C wrote:
> But in prepare_filter_cb callback, by stating "other systems ..." it is 
> not very clear who will change the GID. Are we referring to 
> publisher/subscriber decoding?

Thanks for your feedback.  This is not about GIDs at all, but just about 
identifying a transaction.  I'm out of ideas on how else to phrase that. 
  Any suggestion?

Maybe we should not try to give examples and reference other systems, 
but just leave it at:

      The <parameter>ctx</parameter> parameter has the same contents as for
      the other callbacks. The parameters <parameter>xid</parameter>
      and <parameter>gid</parameter> provide two different ways to identify
      the transaction.  The later <command>COMMIT PREPARED</command> or
      <command>ROLLBACK PREPARED</command> carries both identifiers,
      providing an output plugin the choice of what to use.

That is sufficient an explanation in my opinion.   What do you think?

Regards

Markus



pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: Idea: Avoid JOINs by using path expressions to follow FKs
Next
From: Matthias van de Meent
Date:
Subject: Re: Calendar support in localization