[PATCH] minor bug fix for pg_dump --clean - Mailing list pgsql-hackers

From Frédéric Yhuel
Subject [PATCH] minor bug fix for pg_dump --clean
Date
Msg-id b43e03eb-3997-700e-c2d4-92c31e4e31ee@dalibo.com
Whole thread Raw
Responses Re: [PATCH] minor bug fix for pg_dump --clean
Re: [PATCH] minor bug fix for pg_dump --clean
List pgsql-hackers
Hello,

When using pg_dump (or pg_restore) with option "--clean", there is some 
SQL code to drop every objects at the beginning.

The DROP statement for a view involving circular dependencies is :

CREATE OR REPLACE VIEW [...]

(see commit message of d8c05aff for a much better explanation)

If the view is not in the "public" schema, and the target database is 
empty, this statement fails, because the schema hasn't been created yet.

The attached patches are a TAP test which can be used to reproduce the 
bug, and a proposed fix. They apply to the master branch.

Best regards,
Frédéric
Attachment

pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: broken table formatting in psql
Next
From: "Drouvot, Bertrand"
Date:
Subject: Re: [PATCH] Query Jumbling for CALL and SET utility statements