Re: PQinitSSL broken in some use casesf - Mailing list pgsql-hackers

From Merlin Moncure
Subject Re: PQinitSSL broken in some use casesf
Date
Msg-id b42b73150902100713mdbfd64ah706ced5170897a59@mail.gmail.com
Whole thread Raw
In response to Re: PQinitSSL broken in some use casesf  (Magnus Hagander <magnus@hagander.net>)
Responses Re: PQinitSSL broken in some use casesf  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
On Tue, Feb 10, 2009 at 9:32 AM, Magnus Hagander <magnus@hagander.net> wrote:
>> How we worked around it:
>> We solved it by copying the SSL init sequence from fe-secure.c.  Doesn't
>> seem like something that would change very often.  So we
>> init_our_library(), PQinitSSL(0) and then do a few lines of SSL init stuff.
>
> Seems unusual, but certainly not "nearly impossible". But we're back to
> the discussions around the WSA code - our API provides no really good
> place to do this, so perhaps we should just clearly document how it's
> done and how to work around it?

I'm not so sure that's appropriate in this case.  I think the existing
libpq behavior is simply wrong...crypto and ssl are two separate
libraries and PQinitSSL does not expose the necessary detail.  This is
going to break apps in isolated but spectacular fashion when they link
to both pq and crypto for different reasons.

maybe invent a special value to PQinitSSL for ssl only init?

merlin


pgsql-hackers by date:

Previous
From: Amit Gupta
Date:
Subject: Re: Table Partitioning Feature
Next
From: Magnus Hagander
Date:
Subject: Re: PQinitSSL broken in some use casesf