Re: libpq object hooks - Mailing list pgsql-patches

From Merlin Moncure
Subject Re: libpq object hooks
Date
Msg-id b42b73150805161317v3e9803b8t368eb0bc5c4b51b1@mail.gmail.com
Whole thread Raw
In response to Re: libpq object hooks  ("Merlin Moncure" <mmoncure@gmail.com>)
List pgsql-patches
On Fri, May 16, 2008 at 3:49 PM, Merlin Moncure <mmoncure@gmail.com> wrote:
> On Fri, May 16, 2008 at 2:34 PM, Andrew Chernow <ac@esilo.com> wrote:
>> Tom Lane wrote:
>>>
>>> typedef void (*PGeventProc) (PGeventId eventId, const void *eventInfo,
>>>                             void *passthrough);
>>>
>>> int PQregisterEventProc(PGconn *conn, PGeventProc proc, void
>>> *passthrough);
>
>> The above prototypes will work and we will add our 'event instance pointer'
>> to the event info structures.  Should have a patch shortly.
>
>
> Right.  I actually overlooked the 'passthrough' in
> PQregisterEventProc.  It turns out that we are still not quite on the
> same page and this needs to be clarified before we move on.  The
> passthrough cannot exist...the correct prototypes (reasoning will
> follow) are:
>
> typedef void (*PGeventProc) (PGeventId eventId, const void *eventInfo);

small typo: eventInfo obviously can't be const

> int PQregisterEventProc(PGconn *conn, PGeventProc proc);
> PQhookData(const PGconn* conn, PGeventProc proc);

PQhookData is the old name...we are going with 'events' now....the
proper names will come with the patch.

merlin

pgsql-patches by date:

Previous
From: "Merlin Moncure"
Date:
Subject: Re: libpq object hooks
Next
From: Tom Lane
Date:
Subject: Re: libpq object hooks