On 9/18/06, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> "Merlin Moncure" <mmoncure@gmail.com> writes:
> > yes, i can explain it in detail, and am willing to kick in some
> > documentation.
>
> Ah-hah, you're on the hook for docs then ;-).
sure no problem. the prototypes you suggested are imo the way to go,
with two small considerations:
is it worth considering using the oid type instead of int4 since the
'locktag' fields are unsigned?
also, the userlocks raised a warning if you tried to release a
non-existing lock. should that stay or go?
> As far as the PR material goes, something like "advisory locks
> incorporated into core" would be OK, but don't make it sound like
> there was nothing there before ...
ok, thats a good compromise.
merlin
