Postgres Pro
Downloads
Home   >   mailing lists

Re: backend *.c #include cleanup (IWYU) - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: backend *.c #include cleanup (IWYU)
Date
Msg-id b3e514f8-4fa3-4a1f-b3c2-7dcb3cd9b20b@eisentraut.org
Whole thread Raw
In response to Re: backend *.c #include cleanup (IWYU)  (Nathan Bossart <nathandbossart@gmail.com>)
Responses Re: backend *.c #include cleanup (IWYU)
Re: backend *.c #include cleanup (IWYU)
List pgsql-hackers
Tree view 
On 10.02.24 21:13, Nathan Bossart wrote:
>> (Interestingly, IWYU has been mentioned in src/tools/pginclude/README since
>> 2012.  Has anyone else played with it?  Was it not mature enough back then?)
> I haven't played with it at all, but the topic reminds me of this thread:
> 
>     https://postgr.es/m/flat/CALDaNm1B9naPDTm3ox1m_yZvOm3KA5S4kZQSWWAeLHAQ%3D3gV1Q%40mail.gmail.com

Approaches like that as well as the in-tree pgrminclude work by "I 
removed the #include and it still compiled fine", which can be 
unreliable.  IWYU on the other hand has the compiler tracking where a 
symbol actually came from, and so if it says that an #include is not 
used, then it's pretty much correct by definition.

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: clarify equalTupleDescs()
Next
From: Tom Lane
Date:
Subject: Re: cpluspluscheck complains about use of register