Re: psql - add SHOW_ALL_RESULTS option - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: psql - add SHOW_ALL_RESULTS option
Date
Msg-id b3b4a89f-9dd8-dcc3-d75d-118ec80ce471@enterprisedb.com
Whole thread Raw
In response to Re: psql - add SHOW_ALL_RESULTS option  (Fabien COELHO <coelho@cri.ensmp.fr>)
List pgsql-hackers
On 17.03.22 19:04, Fabien COELHO wrote:
> Indeed! The missing part was put back in v17.

Some unrelated notes on this v17 patch:

-use Test::More;
+use Test::More tests => 41;

The test counts are not needed/wanted anymore.


+
+\set ECHO none
+

This seems inappropriate.


+--
+-- autocommit
+--

+--
+-- test ON_ERROR_ROLLBACK
+--

This test file already contains tests for autocommit and 
ON_ERROR_ROLLBACK.  If you want to change those, please add yours into 
the existing sections, not make new ones.  I'm not sure if your tests 
add any new coverage, or if it is just duplicate.



pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: SQL/JSON: JSON_TABLE
Next
From: David Rowley
Date:
Subject: Re: Use generation context to speed up tuplesorts