Re: Add ps display while waiting for wal in read_local_xlog_page_guts - Mailing list pgsql-hackers

From Drouvot, Bertrand
Subject Re: Add ps display while waiting for wal in read_local_xlog_page_guts
Date
Msg-id b2481960-4c1b-9811-3ec0-c2ab2f47de9c@gmail.com
Whole thread Raw
In response to Re: Add ps display while waiting for wal in read_local_xlog_page_guts  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Hi,

On 4/13/23 4:29 AM, Tom Lane wrote:
> sirisha chamarthi <sirichamarthi22@gmail.com> writes:
>> pg_create_logical_replication_slot can take longer than usual on a standby
>> when there is no activity on the primary. We don't have enough information
>> in the pg_stat_activity or process title to debug why this is taking so
>> long. Attached a small patch to update the process title while waiting for
>> the wal in read_local_xlog_page_guts. 

Thanks for the patch!

> Any thoughts on introducing a new
>> wait event too?
> 
> set_ps_display is a fairly expensive operation on a lot of platforms,
> so I'm concerned about the overhead this proposal would add.  However,
> getting rid of that pg_usleep in favor of a proper wait event seems
> like a good idea.
> 

+1 for adding a proper wait event.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com



pgsql-hackers by date:

Previous
From: "Drouvot, Bertrand"
Date:
Subject: Re: Add ps display while waiting for wal in read_local_xlog_page_guts
Next
From: Bruce Momjian
Date:
Subject: Re: Partial aggregates pushdown