Hi,
On 11/11/24 12:48, Karina Litskevich wrote:
> ...
>
> I wrote:
>> I hope to look more thoroughly into tab-complete.in.c tomorrow or on
>> Monday to see if there are any other problems I can't see at first
>> glance. I'll send another mail when I get to do this.
>
> As promised, I looked into the new set of patches more closely. Can't
> see any other significant problems. However, you still need to do a
> couple of cosmetic changes.
>
> On Sun, Nov 10, 2024 at 3:43 PM Kirill Reshke <reshkekirill@gmail.com> wrote:
>>> 1) Try to keep comments identical, at least in one piece of code. Right
>>> now you have "CREATE MATERIALIZED VIEW <name>" and "CREATE MATERIALIZED
>>> VIEW <sth>" within three consecutive lines. I can see there was the
>>> same problem before your changes, so it's not exactly your fault. Let's
>>> correct it, though.
>>
>> Ok, sure. I did the correction.
>
> You now have the same problem with "USING <access method>" and
> "USING <am_name>" in v5-0004.
>
> Also, make sure you ran pgindent before creating patches. In v5-0004
> there are comments that are too long for one line, and there is a line
> with a trailing space:
>
> + else if (Matches("CREATE", "MATERIALIZED", "VIEW", MatchAny, "AS") ||
>
> Other than that, everything looks fine to me.
>
I took a quick look at this patch series, and it looks generally fine to
me. Barring objections, I'll get it committed. Yes, there's a couple
cosmetic details, and it needs a pgindent run, but I think I can take
care of that ...
regards
--
Tomas Vondra
