On 10/10/2018 11:10 PM, Christian Ferrari wrote:
> By the way, PyMySQL/mysqlclient-python project
> <https://github.com/PyMySQL/mysqlclient-python> asked me to rename the
> method from "get_native_conn()" to "_get_native_conn()".
>
> I'm not a "naming addicted person", but from the developer point of
> view, using two different methods would be for sure not appreciated...
>
> xar1 = PostgresqlXaResource(rm1.get_native_connection(), "PostgreSQL",
> "dbname=testdb")
> xar2 = MysqlXaResource(rm2._get_native_connection(), "MySQL",
> "localhost,0,lixa,,lixa")
>
> If you don't mind, I kindly ask you to wait a couple of days: I hope to
> close the pull request
> https://github.com/PyMySQL/mysqlclient-python/pull/269 shortly...
I think that _if_ this should go cross-database a method without the
underscore is better. The underscore usually means private and that's
good as long as it is just that. An informal "standard" method name
should not have the "_" in it.
federico
--
Federico Di Gregorio federico.digregorio@dndg.it
DNDG srl http://dndg.it
Gli esseri umani, a volte, sono destinati, per il solo fatto di
esistere, a fare del male a qualcuno. -- Haruki Murakami
