Re: Failures with gcd functions with GCC snapshots GCC and -O3 (?) - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: Failures with gcd functions with GCC snapshots GCC and -O3 (?)
Date
Msg-id alpine.DEB.2.22.394.2106190651240.3211875@pseudo
Whole thread Raw
In response to Re: Failures with gcd functions with GCC snapshots GCC and -O3 (?)  (Thomas Munro <thomas.munro@gmail.com>)
List pgsql-hackers
>>> There was a silent API breakage (same API, different behavior, how nice…)
>>> in llvm main that Andres figured out, which will have to be fixed at some
>>> point, so this is reminder that it is still a todo…
>>
>> If it were *our* todo, that would be one thing; but it isn't.
>
> Over on the other thread[1] we learned that this is an API change
> affecting reference counting semantics[2], so unless there is some
> discussion somewhere about reverting the LLVM change that I'm unaware
> of, I'm guessing we're going to need to change our code sooner or
> later.

Indeed, I'm afraid the solution will have to be on pg side.

> I have a bleeding edge LLVM on my dev machine, and I'm willing to try to 
> reproduce the crash and write the trivial patch (that is, figure out the 
> right preprocessor incantation to detect the version or feature, and 
> bump the reference count as appropriate), if Andres and/or Fabien aren't 
> already on the case.

I'm not in the case, I'm only the one running the farm animal which barks 
too annoyingly for Tom.

-- 
Fabien.

pgsql-hackers by date:

Previous
From: Julien Rouhaud
Date:
Subject: Re: Centralizing protective copying of utility statements
Next
From: Thomas Munro
Date:
Subject: Re: seawasp failing, maybe in glibc allocator