Re: pgbench - allow to create partitioned tables - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: pgbench - allow to create partitioned tables
Date
Msg-id alpine.DEB.2.21.1909262244440.7473@lancre
Whole thread Raw
In response to Re: pgbench - allow to create partitioned tables  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: pgbench - allow to create partitioned tables
List pgsql-hackers
Hello Alvaro,

> pgbench's main() is overly long already, and the new code being added
> seems to pollute it even more.  Can we split it out into a static
> function that gets placed, say, just below disconnect_all() or maybe
> after runInitSteps?

I agree that refactoring is a good idea, but I do not think it belongs to 
this patch. The file is pretty long too, probably some functions could be 
moved to distinct files (eg expression evaluation, variable management, 
...).

> (Also, we seem to be afraid of function prototypes.  Why not move the 
> append_fillfactor() to *below* the functions that use it?)

Because we avoid one more line for the function prototype? I try to put 
functions in def/use order if possible, especially for small functions 
like this one.

-- 
Fabien.



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Standby accepts recovery_target_timeline setting?
Next
From: David Steele
Date:
Subject: Re: Standby accepts recovery_target_timeline setting?