Re: libpq connection timeout mismanagement - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: libpq connection timeout mismanagement
Date
Msg-id alpine.DEB.2.21.1808140909250.27691@lancre
Whole thread Raw
In response to Re: libpq connection timeout mismanagement  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: libpq connection timeout mismanagement
List pgsql-hackers
Hello Tom,

>> connect_timeout=2.9 is accepted and considered as meaning 2.
>> connect_timeout=-10 or connect_timeout=two are also accepted and mean
>> forever. Probably thanks to "atoi".
>
> Right.  As before, I'm not excited about rejecting trailing junk,
> considering we never did before.

My 0.02€: accepting trailing junk is just a recipee for hiding bugs:

  sh> psql "connect_timeout=2,port=5433"
  psql> \conninfo
  ... port=5432 # port directive was silently ignored

So erroring out would be a good thing, and it could be done on a new 
release. At the minimum there should be a warning.

-- 
Fabien.

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Alter index rename concurrently to
Next
From: Masahiko Sawada
Date:
Subject: Re: [HACKERS] WIP: long transactions on hot standby feedback replica/ proof of concept