Re: libpq connection timeout mismanagement - Mailing list pgsql-hackers

From Tom Lane
Subject Re: libpq connection timeout mismanagement
Date
Msg-id 5106.1534267032@sss.pgh.pa.us
Whole thread Raw
In response to Re: libpq connection timeout mismanagement  (Fabien COELHO <coelho@cri.ensmp.fr>)
List pgsql-hackers
Fabien COELHO <coelho@cri.ensmp.fr> writes:
>> Right.  As before, I'm not excited about rejecting trailing junk,
>> considering we never did before.

> My 0.02¤: accepting trailing junk is just a recipee for hiding bugs:
>   sh> psql "connect_timeout=2,port=5433"
>   psql> \conninfo
>   ... port=5432 # port directive was silently ignored
> So erroring out would be a good thing, and it could be done on a new 
> release.

Perhaps.  That should certainly be a separate patch, though, and
it should cover everything not just connection_timeout (I see at
least five parameters that are parsed with atoi() and nothing else).
I'm still not excited, but feel free to send a patch.

            regards, tom lane


pgsql-hackers by date:

Previous
From: "Tels"
Date:
Subject: Re: Undocumented(?) limits on regexp functions
Next
From: Tom Lane
Date:
Subject: Re: Pre-v11 appearances of the word "procedure" in v11 docs