Re: pgbench - add \if support - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: pgbench - add \if support
Date
Msg-id alpine.DEB.2.20.1803211841500.1860@lancre
Whole thread Raw
In response to Re: pgbench - add \if support  (Teodor Sigaev <teodor@sigaev.ru>)
Responses Re: pgbench - add \if support  (Teodor Sigaev <teodor@sigaev.ru>)
List pgsql-hackers
Hello Teodor,

> Patch seems usefull and commitable except comments in conditional.[ch]. I'd 
> like to top/header comment in each file more detailed and descriptive. As for 
> now it mentions only psql usage without explaining how it is basic or common.

Indeed, it was not updated.

I've fixed the file names and added a simple description at the beginning 
of the header file, and a one liner in the code file.

Do you think that more is needed?

The patch also needed a rebase after the hash function addition.

-- 
Fabien.
Attachment

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: [HACKERS] pg_upgrade to clusters with a different WAL segmentsize
Next
From: "Bossart, Nathan"
Date:
Subject: Re: [HACKERS] pg_upgrade to clusters with a different WAL segmentsize