Re: pgbench - add \if support - Mailing list pgsql-hackers

From Teodor Sigaev
Subject Re: pgbench - add \if support
Date
Msg-id 2241beca-1491-6e0d-b457-f593b24a255d@sigaev.ru
Whole thread Raw
In response to Re: pgbench - add \if support  (Fabien COELHO <coelho@cri.ensmp.fr>)
List pgsql-hackers
Thank you, pushed

Fabien COELHO wrote:
> 
> Hello Teodor,
> 
>> Patch seems usefull and commitable except comments in conditional.[ch]. I'd 
>> like to top/header comment in each file more detailed and descriptive. As for 
>> now it mentions only psql usage without explaining how it is basic or common.
> 
> Indeed, it was not updated.
> 
> I've fixed the file names and added a simple description at the beginning of the 
> header file, and a one liner in the code file.
> 
> Do you think that more is needed?
> 
> The patch also needed a rebase after the hash function addition.
> 

-- 
Teodor Sigaev                                   E-mail: teodor@sigaev.ru
                                                    WWW: http://www.sigaev.ru/


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: WIP: a way forward on bootstrap data
Next
From: Tom Lane
Date:
Subject: Re: WIP: a way forward on bootstrap data